usdAbc: Correctly interpret indexed ArbGeomParams from Alembic files #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
boberfly
force-pushed
the
fixes/usdAbc/arbGeomParams
branch
from
9bfdac1 to
7de3d8d
Compare
|
Filed as internal issue #USD-10527 (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
When opening referenced Alembics into a USD stage, the
ArbGeomParamswould tend to follow a code-path which doesn't take indexed values into account. After learning how usdAbc works I saw that it takes a code-path which is treatingArbGeomParamsout-of-schema however it should be using the schema out ofUsdGeomPrimvarsso this code addresses this also.Fixes Issue(s)
Prior to this, we found that loading indexed primvars into Gaffer wouldn't function as intended, @johnhaddon has a demonstration here: ImageEngine/cortex#1415
The custom/out-of-schema functionality prevents the UsdGeomPrimvarsAPI from working, so the indices would come in as attribute constant arrays.
Checklist
[x] I have created this PR based on the dev branch
[x] I have followed the coding conventions
[x] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[ ] I have verified that all unit tests pass with the proposed changes
[x] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)